Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add capability to add and remove a room from the favorites (#1217) #1466

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Add capability to add and remove a room from the favorites (#1217) #1466

merged 1 commit into from
Jun 15, 2020

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Jun 9, 2020

Pull Request Checklist

  • Changes has been tested on an Android device or Android emulator with API 16
  • UI change has been tested on both light and dark themes
  • Pull request is based on the develop branch
  • Pull request updates CHANGES.md
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off

ganfra
ganfra approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this 🙂

@bmarty bmarty merged commit 2c1487d into develop Jun 15, 2020
@bmarty bmarty deleted the feature/toggle_favorite branch June 15, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmarty @ganfra