Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start sync when receive m.call.invite. #2058

Merged
merged 4 commits into from Nov 2, 2020
Merged

Start sync when receive m.call.invite. #2058

merged 4 commits into from Nov 2, 2020

Conversation

onurays
Copy link
Contributor

@onurays onurays commented Sep 4, 2020

Fixes #1921

@progserega
Copy link

Do the sync will stop, when call ended?
In mobile 1.0.7 ring stop ringing after get call on PC, but mobile app start infinity sync-loop: #2163

@BillCarsonFr BillCarsonFr force-pushed the feature/fix_sync_after_call_invite branch from 7c9eee3 to 47abea5 Compare October 30, 2020 10:53
@BillCarsonFr BillCarsonFr force-pushed the feature/fix_sync_after_call_invite branch from 47abea5 to 1de1ddd Compare October 30, 2020 10:53
BillCarsonFr
BillCarsonFr approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few commits LGTM

@bmarty bmarty merged commit 3947a78 into develop Nov 2, 2020
@bmarty bmarty deleted the feature/fix_sync_after_call_invite branch November 2, 2020 13:45
@onurays onurays mentioned this pull request Nov 11, 2020
Closed
@onurays onurays mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incoming call continues to ring if call is answered on another device
4 participants
@onurays @progserega @BillCarsonFr @bmarty