Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Video will not play upon tap #3006

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Regression: Video will not play upon tap #3006

merged 2 commits into from
Mar 16, 2021

Conversation

BillCarsonFr
Copy link
Member

Fixes #2928 (Regression: Video will not play upon tap, but only after swipe)

ganfra
ganfra approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add a TODO to fix that properly?

bmarty
bmarty approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've checked and I see no rageshake with the bug this line should fix. It was just changed as a safety measure.

@bmarty bmarty merged commit 5ce984c into develop Mar 16, 2021
@bmarty bmarty deleted the feature/bca/fix_video_wont_play branch March 16, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: Video will not play upon tap, but only after swipe
3 participants
@BillCarsonFr @bmarty @ganfra