Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved /settings/notifications push toggle error handling #4062

Closed
wants to merge 12 commits into from
Closed

Improved /settings/notifications push toggle error handling #4062

wants to merge 12 commits into from

Commits on Oct 1, 2021

  1. extracting the add pusher logic for the worker and delegating to the … 

    …task from the worker
    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    d74dedb View commit details
    Browse the repository at this point in the history

  2. reusing the transactional logic for the current session notifications… 

    … toggle

- uses the synchronous token registering which also means we get error handling
    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    2d572cb View commit details
    Browse the repository at this point in the history

  3. running lint

    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    82c0c19 View commit details
    Browse the repository at this point in the history

  4. removing comment which doesn't add additional context/information

    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    eb8d6a5 View commit details
    Browse the repository at this point in the history

  5. creating an injectable request executor to enable unit tests network … 

    …request (without hitting the network)
    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    b7262c9 View commit details
    Browse the repository at this point in the history

  6. including rx java dependency for the sdk tests because real (monarchy… 

    …) tranisitive depends on rx but doesn't propagate it as an API dependency

- without an explicit declaration we can't mock the realm instance
    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    d3bce76 View commit details
    Browse the repository at this point in the history

  7. adding test for the add pusher task happy flow 

    - introduces the concepts of Fakes for handling the dependencies, unforuntately realm/monarchy aren't very testable in their current state so we'll need to use mocks
    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    0bb81ed View commit details
    Browse the repository at this point in the history

  8. inverting if to favour positive ordering

    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    01a1653 View commit details
    Browse the repository at this point in the history

  9. adding test cases for when adding a pusher fails and when it already … 

    …exists
    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    317a817 View commit details
    Browse the repository at this point in the history

  10. removing unused import

    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    87f0f3d View commit details
    Browse the repository at this point in the history

  11. extracting the test fakes to their own package

    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    2693a34 View commit details
    Browse the repository at this point in the history

  12. lifting the request executor to its own file in the network package 

    - also creates a dedicated RequestModule instead of providing the executor via the pushers module
    @ouchadam
    ouchadam committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    e82de2b View commit details
    Browse the repository at this point in the history