Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC - Staleness action for Element team PRs #5742

Closed
wants to merge 1 commit into from

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Apr 12, 2022

Introduces a staleness github action to mark stale and close Element team member PRs

  • PRs are marked as stale after 30 days of inactivity (PRs without the Z-Community-PR label)
  • After 14 days of being stale the PR is closed

@ouchadam ouchadam force-pushed the feature/adm/stale-prs branch 4 times, most recently from d87e2bb to aeb868a Compare April 12, 2022 10:39
@github-actions
Copy link

github-actions bot commented Apr 12, 2022

Unit Test Results

114 files  ±0  114 suites  ±0   1m 31s ⏱️ +10s
201 tests ±0  201 ✔️ ±0  0 💤 ±0  0 ±0 
674 runs  ±0  674 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 59a3d8d. ± Comparison against base commit 047a45d.

♻️ This comment has been updated with latest results.

@ouchadam
Copy link
Contributor Author

ouchadam commented Apr 12, 2022

The action would mark these as stale (and in 14 days without update close)

#4364
#4333
#4186
#4987
#5006
#5168
#5287
#5187
#5170
#5023

https://github.com/vector-im/element-android/runs/5988449277?check_suite_focus=true

@@ -0,0 +1,20 @@
name: 'Close stale issues and PRs'
on:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be swapped to an hourly cron if approved

steps:
- uses: sonia-corporation/stale@1.54.0
with:
dry-run: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be removed if we're happy with the output

stale:
runs-on: ubuntu-latest
steps:
- uses: sonia-corporation/stale@1.54.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uses a staleness action fork to allow for only checking PRs instead of PRs and issues which causes the rate limit to be hit due to our large amount of issues

@ouchadam ouchadam changed the title Testing staleness action PoC - Staleness action for Element team PRs Apr 12, 2022
@bmarty
Copy link
Member

bmarty commented Apr 13, 2022

I do not like stale bot for PR, or for issues. In the list you have provided, there are a lot of PRs that must finally be merged...

We are late to review PRs, but here the sanction is more for the submitter :/

1 similar comment
@bmarty
Copy link
Member

bmarty commented Apr 13, 2022

I do not like stale bot for PR, or for issues. In the list you have provided, there are a lot of PRs that must finally be merged...

We are late to review PRs, but here the sanction is more for the submitter :/

@ouchadam
Copy link
Contributor Author

closing as this can be used as a PoC reference without needing to be open

@ouchadam ouchadam closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants