Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document need for public_baseurl to be correctly set. #5973

Merged
merged 4 commits into from
May 16, 2022

Conversation

michaelkaye
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Docs

Content

In #5949 we corrected the public_baseurl for the integration tests in github actions. This PR adds a note to the troubleshooting of integration tests about the similar failure when it occurs locally.

Motivation and context

Docs are good :)

Checklist

@github-actions
Copy link

github-actions bot commented May 9, 2022

Unit Test Results

122 files  ±0  122 suites  ±0   2m 7s ⏱️ -6s
205 tests ±0  205 ✔️ ±0  0 💤 ±0  0 ±0 
690 runs  ±0  690 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 2bd89e6. ± Comparison against base commit 0b00f97.

♻️ This comment has been updated with latest results.

@michaelkaye michaelkaye marked this pull request as ready for review May 13, 2022 10:41
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty merged commit 15366f8 into develop May 16, 2022
@bmarty bmarty deleted the michaelk/document_public_baseurl_requirement branch May 16, 2022 09:27
@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    = passed=15 failures=5 errors=0 skipped=3
  • [org.matrix.android.sdk.account]
    = passed=3 failures=0 errors=0 skipped=2
  • [org.matrix.android.sdk.internal]
    = passed=93 failures=54 errors=0 skipped=13
  • [org.matrix.android.sdk.ordering]
    = passed=93 failures=54 errors=0 skipped=13
  • [org.matrix.android.sdk.PermalinkParserTest]
    = passed=2 failures=0 errors=0 skipped=0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants