Remove remaining dead code about flair #6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finish the work started at #5664
bmarty
requested review from
a team,
Claire1817 and
ericdecanini
and removed request for
a team
bmarty
commented
May 11, 2022
| <im.vector.app.core.preference.VectorPreference | ||
| android:icon="@drawable/ic_settings_root_flair" | ||
| android:title="@string/settings_flair" | ||
| app:fragment="im.vector.app.features.settings.VectorSettingsFlairFragment" |
There was a problem hiding this comment.
This Fragment has already been deleted in #5664
bmarty
commented
May 11, 2022
| @@ -8,12 +8,6 @@ | |||
| app:fragment="im.vector.app.features.settings.VectorSettingsGeneralFragment" | |||
| app:isPreferenceVisible="@bool/settings_root_general_visible" /> | |||
|
|
|||
| <im.vector.app.core.preference.VectorPreference | |||
| android:icon="@drawable/ic_settings_root_flair" | |||
| android:title="@string/settings_flair" | |||
There was a problem hiding this comment.
This string is already marked as "to be deleted"
Claire1817
approved these changes
May 12, 2022
Matrix SDKIntegration Tests Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish the work started at #5664.
No need for a changelog