Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glide - Use current drawable while loading new static map image (PSF-979) #6103

Merged
merged 2 commits into from May 20, 2022
Merged

Glide - Use current drawable while loading new static map image (PSF-979) #6103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b681a4
Use current drawable while loading new map image.
onurays May 20, 2022
468cc30
Changelog added.
onurays May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/6103.bugfix
View file
Open in desktop
@@ -0,0 +1 @@
Glide - Use current drawable while loading new static map image
1 change: 1 addition & 0 deletions ...main/java/im/vector/app/features/home/room/detail/timeline/item/AbsMessageLocationItem.kt
View file
Open in desktop
Expand Up @@ -75,6 +75,7 @@ abstract class AbsMessageLocationItem<H : AbsMessageLocationItem.Holder> : AbsMe
GlideApp.with(holder.staticMapImageView)
.load(location)
.apply(RequestOptions.centerCropTransform())
.placeholder(holder.staticMapImageView.drawable)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems to come from this suggestion: bumptech/glide#2505 (comment)

It's not recommended to use that in RecyclerView, which is the case here (see the comments below).

I should work, but may lead to some issue.

Not a blocker anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems to come from this suggestion: bumptech/glide#2505 (comment)

Exactly, I couldn't find any other solutions. I could understand the below comment if we were setting the actual source but we are just setting the placeholder.

  • We are going to have a test session next week.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm agree with @bmarty about this fix. Further tests are needed.

.listener(object : RequestListener<Drawable> {
override fun onLoadFailed(e: GlideException?,
model: Any?,
Expand Down