Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid manual line breaks in exit onboarding dialog copy #6223

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Avoid manual line breaks in exit onboarding dialog copy #6223

merged 2 commits into from
Jun 14, 2022

Conversation

ouchadam
Copy link
Contributor

@ouchadam ouchadam commented Jun 1, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Copy

Content

Fixes #6087 Updates the copy formatting to match iOS (android/material avoids centered text in dialogs)

  • Doesn't update script based languages as I'm not sure how the sentence should be structured.

Motivation and context

To match iOS

Screenshots / GIFs

Before After
Screenshot_20220601_150551 Screenshot_20220601_145612

Tests

  • Start creating an account (after submitting username/password)
  • Press back

Tested devices

  • Physical
  • Emulator
  • OS version(s): 28

@ouchadam ouchadam added Z-FTUE Issue is relevant to the first time use project or experience PR-Small PR with less than 20 updated lines X-Needs-Design May require input from the design team labels Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Unit Test Results

146 files  ±0  146 suites  ±0   2m 51s ⏱️ +6s
236 tests ±0  236 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
788 runs  ±0  788 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 01dad8b. ± Comparison against base commit 033b877.

@ouchadam ouchadam removed the X-Needs-Design May require input from the design team label Jun 1, 2022
@ouchadam
Copy link
Contributor Author

ouchadam commented Jun 1, 2022

checked in with design and got the 👍

@ouchadam ouchadam requested review from a team, bmarty and ericdecanini and removed request for a team June 1, 2022 15:50
bmarty
bmarty requested changes Jun 2, 2022
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but blocking the PR since it has to be merged only during the time Weblate is locked, to avoid painful merge conflict with Weblate.

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Jun 7, 2022
@bmarty
Copy link
Member

bmarty commented Jun 7, 2022

I added the Z-NextRelease label to think about this PR when we will prepare the next release.

@ouchadam
Copy link
Contributor Author

weblate is locked, will merge

@ouchadam ouchadam merged commit 11b0ed9 into develop Jun 14, 2022
@ouchadam ouchadam deleted the feature/adm/exit-onboarding-copy branch June 14, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty requested changes

@ericdecanini ericdecanini ericdecanini approved these changes

Assignees
No one assigned
Labels
PR-Small PR with less than 20 updated lines Z-FTUE Issue is relevant to the first time use project or experience Z-NextRelease For issues and PRs which should be included in the NextRelease. Z-Weblate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update exit FTUE copy formatting
3 participants
@ouchadam @bmarty @ericdecanini