Merging Element R in Element Android as a new flavor #7628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the rust-sdk to support fallback keys, note that fallback keys are not yet uploaded, they just can be used when downloaded and info about the fallback keys coming from a sync can be passed to the rust side.
If there's an invalid user id that gets passed to the Rust side we're going to throw an error, this error doesn't tell us what is invalid nor what the string contained. Add the string that is being parsed to the error so that the log line becomes actionable.
…into rust_upstream_develop
Rust upstream develop
BillCarsonFr
force-pushed
the
feature/bca/rust_flavor
branch
from
801a631
to
425cbc9
Compare
ElementBot
reviewed
Apr 20, 2023
| dependencies { | ||
| implementation libs.jetbrains.coroutinesCore | ||
| implementation libs.jetbrains.coroutinesAndroid | ||
|
|
||
|
|
||
| // implementation(name: 'crypto-android-release', ext: 'aar') | ||
| implementation 'net.java.dev.jna:jna:5.10.0@aar' |
There was a problem hiding this comment.
⚠️ A newer version of net.java.dev.jna:jna than 5.10.0 is available: 5.13.0⚠️ A newer version of net.java.dev.jna:jna than 5.10.0 is available: 5.13.0
| @@ -121,6 +127,6 @@ internal class MegolmSessionDataImporter @Inject constructor( | |||
|
|
|||
| Timber.tag(loggerTag.value).v("## importMegolmSessionsData : sessions import " + (t1 - t0) + " ms (" + megolmSessionsData.size + " sessions)") | |||
There was a problem hiding this comment.
⚠️ Replace String concatenation with Timber's string formatting⚠️ Replace String concatenation with Timber's string formatting
| @@ -127,32 +125,34 @@ class DevicesViewModelTest { | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore | |||
There was a problem hiding this comment.
⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation
| } | ||
|
|
||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation
| @@ -107,36 +105,38 @@ class OtherSessionsViewModelTest { | |||
| } | |||
|
|
|||
| @Test | |||
| @Ignore | |||
There was a problem hiding this comment.
⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation
| } | ||
|
|
||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation
| } | ||
| } | ||
|
|
||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation⚠️ Test is ignored without giving any explanation
|
SonarCloud Quality Gate failed.
|
bmarty
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Integration of the rust crypto crate in Element Android.
Currently it's a bit hard to extract a clean crypto-backend API that could be implemented in rust or kotlin.
As a first step and to avoid disruption on the kotlin side, the code is separated as different source sets
Task:
Create a new flavor dimension for rust vs kotlin
Suspendable Verification:
Fix unit tests
Rust parity
Clear various debug/dev logs (VALR.., ##)
...
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist