Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7758: Fixed JWT token for Jitsi openidtoken-jwt authentication #8341

Merged
merged 1 commit into from Aug 28, 2023

Conversation

tomtit
Copy link
Contributor

@tomtit tomtit commented Apr 18, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Used the hard-coded key from the module prosody-mod-auth-matrix-user-verification to sign the JWT for Jitsi openidtoken-jwt authentication to pass token validation at Prosody side.

Motivation and context

#7758

Screenshots / GIFs

Tests

  • start a group video call
  • get into the video call

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 6.0, Android 10.0

Checklist

…entication

Signed-off-by: Alexey Nechaev <seysane@yahoo.com>
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label May 11, 2023
@langleyd langleyd self-requested a review August 28, 2023 11:11
Copy link
Contributor

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over these changes and have tested them on an environment where I could reproduce the issue. Thanks for fix!

@bmarty
Copy link
Member

bmarty commented Aug 28, 2023

Thanks @langleyd . I do not see how to trigger the CI again, but I think this is fine to merge the PR. I can handle issue if it breaks something.

@bmarty bmarty merged commit a3be028 into element-hq:develop Aug 28, 2023
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants