Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sound on vb network error #8389

Merged
merged 1 commit into from May 4, 2023
Merged

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented May 3, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

#8339

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested a review from giomfo May 3, 2023 09:14
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@yostyle yostyle enabled auto-merge (squash) May 3, 2023 12:20
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yostyle yostyle merged commit f3faed0 into develop May 4, 2023
18 checks passed
@yostyle yostyle deleted the yostyle/add_audio_alert branch May 4, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants