Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust Crypto SDK is now the default, and the build will replace the existing application #8390

Merged
merged 16 commits into from May 11, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 3, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Enable usage of Crypto Rust SDK.

Motivation and context

Share crypto code with other Element client!

Screenshots / GIFs

Tests

  • Upgrade application and check that everything is still working. User's data is migrated at first launch.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr force-pushed the feature/bma/crypto_rust_default branch from bb31a2d to f1036d4 Compare May 8, 2023 13:37
@bmarty bmarty force-pushed the feature/bma/crypto_rust_default branch from 8baa485 to 421d996 Compare May 9, 2023 20:12
@bmarty bmarty requested a review from BillCarsonFr May 9, 2023 20:15
@bmarty
Copy link
Member Author

bmarty commented May 9, 2023

@BillCarsonFr I have rebased the branch and removed the temporary commit. Also added a changelog entry at 421d996

I let you merge the PR once the CI is happy?

@bmarty bmarty marked this pull request as ready for review May 9, 2023 20:16
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label May 9, 2023
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@BillCarsonFr BillCarsonFr merged commit b2cde3f into develop May 11, 2023
16 of 17 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/bma/crypto_rust_default branch May 11, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants