Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LegacySessionImporter #8402

Merged
merged 2 commits into from May 8, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented May 5, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Remove LegacySessionImporter, and the dialog which explains that Riot is now Element.

Motivation and context

We can consider that users and even fork are all migrated to Element now. Also keeping the LegacySessionImporter will require more work to migrate to ElementR and to ElementX.

Drawback: If by any chance user upgrades from Riot to Element after the PR is merged, the user will have to login again, and the legacy data will not be deleted from the device.

Screenshots / GIFs

Tests

  • Start the app.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty force-pushed the feature/bma/removeLegacySessionImporter branch from 7f9da89 to 622aa88 Compare May 5, 2023 14:04
@bmarty bmarty requested review from a team and jonnyandrew and removed request for a team May 5, 2023 14:46
@BillCarsonFr BillCarsonFr self-requested a review May 5, 2023 15:45
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BillCarsonFr BillCarsonFr merged commit 79b4515 into develop May 8, 2023
17 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/bma/removeLegacySessionImporter branch May 8, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants