Fix crashes #8410
Merged
Fix crashes #8410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
added
the
Z-NextRelease
Florian14
reviewed
May 9, 2023
| if (positionOfReadMarker == null) { | ||
| false | ||
| withResumed { | ||
| viewLifecycleOwner.lifecycleScope.launch { |
There was a problem hiding this comment.
Is it expected to have this line twice?
There was a problem hiding this comment.
it seems since this is done at several places
There was a problem hiding this comment.
Yes, we are not in a coroutine scope in the withResumed block.
|
SonarCloud Quality Gate failed. |
Florian14
reviewed
May 11, 2023
| @@ -81,9 +79,7 @@ class LocationPreviewFragment : | |||
| views.mapView.onCreate(savedInstanceState) | |||
|
|
|||
| viewLifecycleOwner.lifecycleScope.launch { | |||
| viewLifecycleOwner.repeatOnLifecycle(Lifecycle.State.CREATED) { | |||
There was a problem hiding this comment.
I don't know if this code was here for a certain reason, but I agree that it does not seem necessary since we're in the onViewCreated method
Florian14
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
repeatOnLifecyclewas not used properly. This PR does some cleanup.Reviewer: please ignore spaces when comparing.
Motivation and context
Fixes #8409
Screenshots / GIFs
Tests
Tested devices
Checklist