Fix various crashes an 1.5.30, observed when no network is available. #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… network when displaying the BootstrapBottomSheet.
…and there is no network.
jmartinesp
approved these changes
Jun 19, 2023
BillCarsonFr
approved these changes
Jun 26, 2023
| @@ -82,7 +83,9 @@ internal class SyncResponsePostTreatmentAggregatorHandler @Inject constructor( | |||
| } | |||
| } | |||
| if (hasUpdate) { | |||
| updateUserAccountDataTask.execute(UpdateUserAccountDataTask.DirectChatParams(directMessages = directChats)) | |||
| tryOrNull("Unable to update user account data") { | |||
There was a problem hiding this comment.
If it fails will it retry next sync or is lost?
There was a problem hiding this comment.
If it fails, it will not be retried on next sync.
Merged
|
Replaced by #8578 on top of develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Fix several crashes observed when the device cannot reach the homeserver. The main change is regarding the BootstrapBottomSheet. There is new screen displayed when the device is not able to get the KeyBackup status:
The others fixes are smaller, into dedicated commits.
Note This PR is base on Element Android 1.5.30 version (commit 0b09a51) but will be created again on the latest develop branch.
Motivation and context
Improve stability of the application.
Screenshots / GIFs
Tests
Set up Secure BackupinSettings/Security & PrivacyAllow integrationinSettings/GeneralTested devices
Checklist