Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SAS strings import URL #8623

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Fix SAS strings import URL #8623

merged 2 commits into from
Aug 23, 2023

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 22, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

See #8525

Motivation and context

N/A

Screenshots / GIFs

N/A

Tests

N/A

Tested devices

N/A

Checklist


Signed-off-by: Travis Ralston travis.ralston@matrix.org
Signed-off-by: Travis Ralston travis.ralston@element.io

@turt2live turt2live requested a review from a team August 22, 2023 18:15
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Florian14 Florian14 merged commit a5d231c into develop Aug 23, 2023
19 checks passed
@Florian14 Florian14 deleted the travis/fix-sas-import branch August 23, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants