Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the incoming call will not ring forever, in case the call is not ended by another way #8660

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Oct 6, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Ensure the incoming call will not ring forever, in case the call is not ended by another way.
Add a safe 2 minutes timer.

Motivation and context

Fixes #8178

Screenshots / GIFs

Tests

  • Receive a call, the phone rings
  • move to airplane mode
  • without the patch: the phone rings forever
  • with the patch: the phone stop ringing after 2 minutes

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

…ot ended by another way (#8178)

Add a safe 2 minutes timer.
@bmarty bmarty requested a review from ganfra October 6, 2023 08:46
Copy link
Contributor

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM not tested

@bmarty bmarty merged commit ebc81e2 into develop Oct 6, 2023
16 of 17 checks passed
@bmarty bmarty deleted the feature/bma/stopInfiniteRingingCall branch October 6, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants