Update regex for email address to be aligned on RFC 5322 #8671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signed-off-by: yostyle y.pintas@gmail.com |
yostyle
force-pushed
the
yostyle/update_email_regex
branch
from
b34b3fa
to
b9535ac
Compare
bmarty
reviewed
Nov 7, 2023
| @@ -29,7 +30,7 @@ inline fun <T> T.ooi(block: (T) -> Unit): T = also(block) | |||
| /** | |||
| * Check if a CharSequence is an email. | |||
| */ | |||
| fun CharSequence.isEmail() = Patterns.EMAIL_ADDRESS.matcher(this).matches() | |||
| fun CharSequence.isEmail() = this.isEmail() | |||
There was a problem hiding this comment.
Reading it from GitHub, it looks like an infinite loop (it's maybe one?).
Maybe remove this extension for clarity. The call site can import org.matrix.android.sdk.api.extensions.isEmail instead?
There was a problem hiding this comment.
Yes I removed this extension.
Signed-off-by: yostyle <y.pintas@gmail.com>
yostyle
force-pushed
the
yostyle/update_email_regex
branch
from
b9535ac
to
3d7489c
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Update regex for email address to be aligned on RFC 5322
Similar to Matrix React SDK
Motivation and context
Some characters in email address are not allowed in Element Android but should be accepted according to RFC 5322.
Tested devices
Checklist