Message search indexing infinite loop

[foresto]

Steps to reproduce

1. Disable message search.
2. Enable message search.
3. Watch the indexing status progress.

Outcome

What did you expect?

I expected indexing to progress until it was complete, as it did when I last had message search enabled, months ago.

What happened instead?

Indexing progressed steadily for a while, but the indexed messages count eventually stopped rising, and the indexed rooms count never reached my total number of rooms.

Once I was convinced that it was in an infinite loop, I opened the Electron/Chromium console, and found this message endlessly repeating:

rageshake.ts:74 EventIndex: Error during a crawl {message: 'Event has an invalid avatar URL'}

Operating system

Linux

Application version

1.11.31

How did you install the app?

Flatpak, which packages the official binary from element-desktop-1.11.31.tar.gz

Homeserver

matrix.org

Will you send logs?

No, because I'm uncomfortable blindly sending data without a chance to redact sensitive info, but I can gather specific information if it will help.

[t3chguy]

@MatMaul / @poljar do you know if the above error coming out of Seshat would cause indexing to get wedged?

[poljar]

Yeah I think so. Any way to figure out which event and avatar URL it is?

[t3chguy]

No, because I'm uncomfortable blindly sending data without a chance to redact sensitive info, but I can gather specific information if it will help.

@foresto then download the logs and redact them as you see fit?

The contextual logs around the error you shared in the console would be helpful.

@poljar not that I can see, what sort of values would yield that error? The interface defines avatar_url as ?: string - would null makes things sad or things more esoteric only?

[foresto]

@foresto then download the logs and redact them as you see fit?

What specific log file do you want? Element has a "submit debug logs" button, but I haven't clicked it because I don't want it submitting anything on its own.

The contextual logs around the error you shared in the console would be helpful.

The context in the javascript console is just more of the same error I already posted, over and over again. If there's some other context you want, please specify it.

[t3chguy]

What specific log file do you want? Element has a "submit debug logs" button, but I haven't clicked it because I don't want it submitting anything on its own.

Once you click it you have the option to add a message and send, or download the logs for your own perusal.

[poljar]

@poljar not that I can see, what sort of values would yield that error? The interface defines avatar_url as ?: string - would null makes things sad or things more esoteric only?

Good point, might be a recent regression due to the neon bump: matrix-org/seshat#128

[t3chguy]

@poljar could you get that PR into a release by early tomorrow so we can get it into the RC tomorrow? Thanks

[poljar]

@poljar could you get that PR into a release by early tomorrow so we can get it into the RC tomorrow? Thanks

Did so: https://www.npmjs.com/package/matrix-seshat/v/3.0.1

[foresto]

Once you click it you have the option to add a message and send, or download the logs for your own perusal.

Ah. That button would be more helpful if it was labeled "Submit or download debug logs". I set out to make a patch for that, but I don't see where the string is defined. Searching for it in element-web and element-desktop yields no results.

then download the logs and redact them as you see fit?

The downloaded logs are over 5MB. I'm not going to comb through all of that to redact certain parts, so we're back to what I wrote in the first place: I can gather specific information if it will help. But you'll have to be specific. (BTW, I don't know how you intended it, but your tone in that comment comes of as somewhat less than respectful.)

In any case, I see there's a potential fix slated for the next release, so I'll plan to give it a try and report back here.

[t3chguy]

I don't see where the string is defined.

https://github.com/matrix-org/matrix-react-sdk has the majority of the app

This issue will be closed by the linked PR, if after that changeset makes it into the version you're running you still encounter this issue you'd need to provide all logs relating even tangentially to the event index and/or seshat or await someone else to do so. Thanks

[foresto]

Seems to be fixed in 1.11.32