Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows MSI package support #387

Merged
merged 5 commits into from
Jul 11, 2022
Merged

Windows MSI package support #387

merged 5 commits into from
Jul 11, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 6, 2022

Fixes element-hq/element-web#22658

image
image


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Jul 6, 2022
@t3chguy

This comment was marked as outdated.

@t3chguy
Copy link
Member Author

t3chguy commented Jul 8, 2022

Merge blocked on internal delivery discussions

@t3chguy t3chguy changed the title Second attempt at MSI support Windows MSI package support Jul 8, 2022
@t3chguy t3chguy marked this pull request as ready for review July 8, 2022 15:56
@t3chguy t3chguy requested a review from a team as a code owner July 8, 2022 15:56
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's terrifying how simple this is, but lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build MSI installers for Electron Desktop
2 participants