Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Altering DMness of rooms is broken #1370

Closed
ara4n opened this issue Jun 30, 2017 · 3 comments
Closed

Altering DMness of rooms is broken #1370

ara4n opened this issue Jun 30, 2017 · 3 comments
Assignees
@giomfo
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@ara4n
Copy link
Member

ara4n commented Jun 30, 2017 •
edited

There is also no way to alter DMness from Room Settings.
@ara4n
Copy link
Member Author

ara4n commented Jul 19, 2017

Worse still, selecting DMness from the Room list swipe-menu doesn't seem to work at all; it just retains the same shape.

@ara4n ara4n changed the title We need ability to select DMness from Room Settings Altering DMness of rooms is broken Jul 19, 2017
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 labels Sep 19, 2017
@giomfo giomfo self-assigned this Sep 19, 2017
@giomfo
Copy link
Member

giomfo commented Sep 19, 2017

matrix-org/matrix-ios-sdk#368 should fixed this issue.

But I observed the room list is not refreshed correctly. The room is still present in people list whereas we alter its DMness. The room disappears when we force a refresh.

giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Sep 20, 2017
@giomfo
Bug Fix - Refresh the rooms list synchronously when the user alters D…
c7e053e 
…Mness of rooms.

element-hq/element-ios#1370
@giomfo giomfo mentioned this issue Sep 20, 2017
Merged
giomfo added a commit that referenced this issue Sep 20, 2017
@giomfo
Improvement: Alter DMness from Room Settings.
8ee6e6f 
#1370
@giomfo giomfo mentioned this issue Sep 20, 2017
Merged
giomfo added a commit to matrix-org/matrix-ios-sdk that referenced this issue Sep 20, 2017
@giomfo
Bug Fix - Refresh the rooms list synchronously when the user alters D…
42d77d8 
…Mness of rooms.

Post direct rooms change notification on success, and  restore the direct rooms on failure.

element-hq/element-ios#1370
@giomfo
Copy link
Member

giomfo commented Sep 20, 2017

fixed

@giomfo giomfo closed this as completed Sep 20, 2017
@giomfo giomfo mentioned this issue Oct 27, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giomfo giomfo

Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @giomfo