Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow '@' in room alias #1977

Closed
manuroe opened this issue Aug 14, 2018 · 2 comments
Closed

Allow '@' in room alias #1977

manuroe opened this issue Aug 14, 2018 · 2 comments
Labels
parity-with-android T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 13

Comments

@manuroe
Copy link
Member

manuroe commented Aug 14, 2018

#twitter@matrixdotorg:t2bot.io is a valid room alias but not accepted in the room join dialog box

Equivalent of element-hq/riot-android#2079
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems parity-with-android labels Aug 14, 2018
@manuroe manuroe added this to the Sprint 13 milestone Aug 14, 2018
@aaronraimist
Copy link
Contributor

I was able to join #_twitter_@matrixdotorg:t2bot.io on Riot iOS 0.6.20

@manuroe
Copy link
Member Author

manuroe commented Aug 24, 2018

True. Contrary to Riot-Android, Riot-iOS does not validate strings sent to the join request.
The bug will appear on the display. Links will not be created for such room aliases.

@manuroe manuroe changed the title Room join regex is too strict Allow '@' in room alias Sep 21, 2018
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Sep 21, 2018
@manuroe
MXTools: Allow '@' in room alias
c37b3b5 
element-hq/element-ios/issues/1977
@manuroe manuroe mentioned this issue Sep 21, 2018
Merged
@manuroe manuroe closed this as completed Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parity-with-android T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 13
Development

No branches or pull requests
2 participants
@aaronraimist @manuroe