Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Messages do not send and stay in green #2541

Closed
manuroe opened this issue Jul 3, 2019 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#701
Closed

E2E: Messages do not send and stay in green #2541

manuroe opened this issue Jul 3, 2019 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#701
Assignees
@manuroe
Labels
A-E2EE-Key-Backup P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 21

Comments

@manuroe
Copy link
Member

manuroe commented Jul 3, 2019 •
edited

Rageshakes:

To check:
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 A-E2EE-Key-Backup labels Jul 3, 2019
@manuroe manuroe added this to the Sprint 20 milestone Jul 8, 2019
@manuroe manuroe self-assigned this Jul 8, 2019
@manuroe manuroe mentioned this issue Jul 9, 2019
Open
@manuroe
Copy link
Member Author

manuroe commented Jul 22, 2019

matrix-org/riot-ios-rageshakes#2637 reveals that there is a race condition when the code downloads the same devices keys twice in a row.

In that case, the 2nd request displays

[MXDeviceList] downloadKeys: waiting for in-flight query to complete

whereas the 1st request completes just before ([MXDeviceListOperationsPool] doKeyDownloadForUsers -> DONE. Got keys for x users and y devices).

In that race condition, the code forever waits for this no more in-flight query of the 2nd request.

manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 22, 2019
@manuroe
Crypto: Fix a race condition that prevented message from being sent
12db144 
element-hq/element-ios/issues/2541

The full description of the race is given at element-hq/element-ios#2541 (comment)
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jul 22, 2019
@manuroe
Crypto: Add a test for element-hq/element-ios/issues/2541 (Messages d…
d1ff11d 
…o not send and stay in green)
@manuroe manuroe mentioned this issue Jul 22, 2019
Merged
@manuroe manuroe modified the milestones: Sprint 20, Sprint 21 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-E2EE-Key-Backup P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 21
Development

Successfully merging a pull request may close this issue.

Crypto: Fix a race condition that prevented message from being sent matrix-org/matrix-ios-sdk
1 participant
@manuroe