Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MXCryptoStore does not store device.algorithm #2896

Closed
manuroe opened this issue Jan 7, 2020 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#762
Closed

MXCryptoStore does not store device.algorithm #2896

manuroe opened this issue Jan 7, 2020 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#762
Assignees
@manuroe
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@manuroe
Copy link
Member

manuroe commented Jan 7, 2020

The serialisation code forgets to serialise the algorithms field :/
This has been buggy for years.
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems story:1 labels Jan 7, 2020
@manuroe manuroe self-assigned this Jan 7, 2020
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 8, 2020
@manuroe
BF: MXCryptoStore does not store device.algorithm
778f712 
element-hq/element-ios#2896

Mitigate stored data by using default olm and megolm algorithms
@manuroe
Copy link
Member Author

manuroe commented Jan 8, 2020

with the fix that includes mitigation, algorithms are back:

Screenshot 2020-01-08 at 11 14 51

This was referenced Jan 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cross-signing foundation matrix-org/matrix-ios-sdk
1 participant
@manuroe