Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room decoration: shields #2906

Closed
manuroe opened this issue Jan 15, 2020 · 2 comments · Fixed by #2962
Closed

Room decoration: shields #2906

manuroe opened this issue Jan 15, 2020 · 2 comments · Fixed by #2962
Assignees
Labels
feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@manuroe
Copy link
Member

manuroe commented Jan 15, 2020

From riot-web created by dbkr: element-hq/element-web#11225

Legend in figma around: https://www.figma.com/file/wwqBo5oAFfk8XKmtd2YaIs/Cross-signing?node-id=2363%3A11

Decorate rooms with black/green/red shields as appropriate.
This decoration should only appear when the cross-signing labs flag is enabled.

(The following describes rooms in terms of users, but updating the shields on users in the UI is left to a separate issue #2905.)

  • Users
    • None: e2e off in the room
    • Black: Encryption is enabled (I don’t care about their devices)
    • Red: I’ve verified them and an unverified device exists or they were previously verified and their cross-signing identity has changed
    • Green: I’ve verified them and all of their devices are verified
  • Rooms
    • None: e2e off in the room
    • Black: Encryption is enabled
    • Red: A red user exists in the room
    • Green: All users are green
    • (The state of all users, including yourself, is considered when decorating a room)

For some additional detail, the shields are meant to layer onto the room icon in both the room list and room header:

2020-01-14 at 12 01

2020-01-14 at 12 02

@manuroe
Copy link
Member Author

manuroe commented Jan 17, 2020

Kamino cloned this issue to vector-im/riot-ios

@manuroe
Copy link
Member Author

manuroe commented Jan 24, 2020

Because of room members lazy loading, we may not have enough data to compute the right shield to display for a room. In this case, use the black shield.
In future, we will load members in background and refresh the black shield with the right one.

@jryans jryans added the story:3 label Jan 28, 2020
@manuroe manuroe assigned manuroe and unassigned SBiOSoftWhare Jan 30, 2020
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Jan 31, 2020
@kittykat kittykat added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants