Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we hide the algo used when turning on encryption #2939

Closed
manuroe opened this issue Jan 24, 2020 · 1 comment · Fixed by matrix-org/matrix-ios-kit#640
Closed

Can we hide the algo used when turning on encryption #2939

manuroe opened this issue Jan 24, 2020 · 1 comment · Fixed by matrix-org/matrix-ios-kit#640
Assignees
@manuroe
Labels
A-E2EE Community PR P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems ui/ux
Milestone
Sprint 25: Cross-...

Comments

@manuroe
Copy link
Member

manuroe commented Jan 24, 2020

From riot-web created by AmandineLP: element-hq/element-web#8829

at least on /app as 'Amandine turned on end-to-end encryption (algorithm m.megolm.v1.aes-sha2)' is ugly as hell
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 story:36 Community PR ui/ux labels Jan 24, 2020
@manuroe manuroe mentioned this issue Jan 24, 2020
Closed
@jryans
Copy link
Contributor

jryans commented Jan 24, 2020

While chatting more with @ara4n, he would like to have some kind of handling of unknown algorithms at the same time as the propose hiding here. I think he came up with a decent approach:

  • When the algorithm is the one we expect (m.megolm.v1.aes-sha2), hide the algorithm as in this existing PR: %(senderName)s turned on end-to-end encryption.
  • For anything else, show the algorithm as unrecognised: %(senderName)s turned on end-to-end encryption (unrecognised algorithm %(algorithm)s).

@manuroe manuroe self-assigned this Jan 30, 2020
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Jan 30, 2020
@manuroe
MXKEventFormatter: E2E, hide the algo used when turning on encryption
050b5a5 
element-hq/element-ios#2939
@manuroe manuroe mentioned this issue Jan 30, 2020
Merged
@jryans jryans added the phase:1 label Feb 12, 2020
@kittykat kittykat added S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-E2EE Community PR P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems ui/ux
Projects
None yet
Milestone
Sprint 25: Cross-signing and e2e by d...
Development

Successfully merging a pull request may close this issue.

MXKEventFormatter: E2E, hide the algo used when turning on encryption matrix-org/matrix-ios-kit
3 participants
@kittykat @jryans @manuroe