megolm session is not shared with entire room

[uhoreg]

When sending an encrypted message, it looks like megolm sessions are only being shared with a subset of the room.

Found via a rageshake.

[manuroe]

The issue is not the same as the android one.

The matrix-ios-sdk already loads all members of a room before encrypting: https://github.com/matrix-org/matrix-ios-sdk/blob/v0.17.9/MatrixSDK/Crypto/MXCrypto.m#L419.

We have an integration test for that: MXLazyLoadingTests.testEncryptedMessage(). This test still passes. The code behaves as expected (the SDK does not know all members before sending the encrypted message).

[jaywink]

@manuroe would more rageshakes help?

[manuroe]

@jaywink , yes please if you know people who have recents issues.

[manuroe]

The first rageshake of this timeline shows that the sdk can have a wrong view of members being in a room.
As it already loaded all members in the past, it thinks it does not need to do it again.

[manuroe]

Moved the issue on the new sprint to keep an eye on it.

[manuroe]

It seems to be fixed.

[manuroe]

We have is again in coming 1.3.0

[manuroe]

The last rageshake is valuable. We have the full log from the last clear cache.
There are 2 weird things:

• the app tried to load all room members only on encryption. It should do it as well on room opening. This is a minor regression bug
• the sdk thought it loaded all room members on the first interaction with the data of the room.

[manuroe]

• the app tried to load all room members only on encryption. It should do it as well on room opening. This is a minor regression bug

This is due to the second bug (code), which is the root issue.