Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in 1.3.0 #4202

Closed
thibaultamartin opened this issue Apr 10, 2021 · 3 comments · Fixed by matrix-org/matrix-ios-sdk#1067
Closed

Regressions in 1.3.0 #4202

thibaultamartin opened this issue Apr 10, 2021 · 3 comments · Fixed by matrix-org/matrix-ios-sdk#1067

Comments

@thibaultamartin
Copy link
Contributor

thibaultamartin commented Apr 10, 2021

Describe the bug
There seem to be several regressions on Element and 1.3.0 on iOS. I couldn’t find reliable reproducers yet, but in the first 30min the following happened at different times, and after killing the app several times:

  • New incoming messages didn’t make it through until the app was killed
  • Typing notification of my peer didn’t disappear, and their message didn’t make it through until the app was killed
  • Message count/read status didn’t change after I read them until the app was killed
  • Push notifications showed a new message on iPhone Lock Screen, and when touching it Element didn’t show the new message until the app was killed. After killing the app, the unread message count is sometimes too high (e.g. message counts displays “3” when only 1 new message wasn’t read)

To Reproduce

I couldn’t find reliable reproducers, it seems to happen randomly in the 10min after the app was killed.

Expected behavior

Messages and typing notifications being sent and displayed in real time

Screenshots

N/A

Smartphone (please complete the following information):

  • Device: iPhone 11 Pro
  • OS: iOS 14.4.2
  • Version: Element iOS 1.3.0 on TestFlight

Additional context

Not much else. Congratulations to the teams for the gorgeous new designs, the UI is really slick. Good luck chasing those bugs, you’re doing great work!

@manuroe
Copy link
Member

manuroe commented Apr 12, 2021

Thanks @thibaultamartin for the report. We are on it.

@manuroe manuroe added this to the Sprint - Element 1.3.1 milestone Apr 12, 2021
@thibaultamartin
Copy link
Contributor Author

I noticed an odd pattern: it looks like push notification keep making it through, but it looks like the rest of the interface model is frozen.

It is possible to navigate in the interface itself, but it looks like the model (i.e. the new incoming messages, the message count changes) is not updated.

@manuroe
Copy link
Member

manuroe commented Apr 12, 2021

You are right. The root cause of those issues are models in the app that do not update. We are missing a UI refresh somewhere.

manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Apr 13, 2021
element-hq/element-ios/issues/4202

The start locked the `asyncTaskQueue` forever preventing next call of resume from resuming the sync stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants