Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move e2ee decryptions out of the main thread #4306

Closed
manuroe opened this issue May 6, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1091
Closed

Move e2ee decryptions out of the main thread #4306

manuroe opened this issue May 6, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1091
Assignees
@manuroe
Labels
A-E2EE A-SyncV2 performance
Milestone
Sprint - Element ...

Comments

@manuroe
Copy link
Member

manuroe commented May 6, 2021

Remove this TODO added 5y ago.

Every decryption blocks the main thread. On my account, an initial sync requires 2179 decryptions. Local decryption is mandatory to:

  • display the last message of every room
  • compute notifications
  • manage calls

Those 2179 decryptions take 12.4s of the main thread on an iPhone X. The usage of the main thread can be visible on incremental sync where the UI can freeze.

Make sure the fix for this issue also fixes #3028
@manuroe manuroe added this to the Sprint - Element 1.4.1 milestone May 6, 2021
@manuroe manuroe self-assigned this May 6, 2021
@manuroe manuroe changed the title Move e2ee decryptions out of the main the main thread Move e2ee decryptions out of the main thread May 6, 2021
This was referenced May 6, 2021
Closed
Merged
@manuroe manuroe mentioned this issue May 19, 2021
Merged
manuroe added a commit that referenced this issue May 19, 2021
@manuroe
Crypto: Do not decrypt synchronously. It asynchronously happens upstr…
ff41ce8 
…eam now

#4306)
@manuroe manuroe mentioned this issue May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-E2EE A-SyncV2 performance
Projects
None yet
Milestone
Sprint - Element 1.4.0
Development

Successfully merging a pull request may close this issue.

MXCrypto: Move decryptions out of the main thread matrix-org/matrix-ios-sdk
1 participant
@manuroe