Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room lists do not decrypt last message of e2ee rooms #4322

Closed
manuroe opened this issue May 12, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1091
Closed

Room lists do not decrypt last message of e2ee rooms #4322

manuroe opened this issue May 12, 2021 · 0 comments · Fixed by matrix-org/matrix-ios-sdk#1091
Assignees
@manuroe
Labels
A-E2EE A-Message-Editing
Milestone
Sprint - Element ...

Comments

@manuroe
Copy link
Member

manuroe commented May 12, 2021

It does not display the new version of the message but:

image
@manuroe manuroe added this to the Sprint - Element 1.3.8 milestone May 12, 2021
@manuroe manuroe self-assigned this May 12, 2021
@manuroe manuroe changed the title Room list updates on edit in an e2e room Room lists do not decrypt last message of e2ee rooms May 12, 2021
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue May 12, 2021
@manuroe
MXEvent: editedEventFromReplacementEvent: Use decrypted replacing eve…
e15de19 
…nt data

It solves 2 things:
 - avoid synchronous decryption
 - decryption of the  MXRoomSummary.lastMessageEvent when it is edited (element-hq/element-ios/issues/4322)

Plus it saves a decryption.
@manuroe manuroe mentioned this issue May 14, 2021
Merged
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue May 19, 2021
@manuroe
MXEvent: editedEventFromReplacementEvent: Use decrypted replacing eve…
fbde49c 
…nt data

It solves 2 things:
 - avoid synchronous decryption
 - decryption of the  MXRoomSummary.lastMessageEvent when it is edited (element-hq/element-ios/issues/4322)

Plus it saves a decryption.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-E2EE A-Message-Editing
Projects
None yet
Milestone
Sprint - Element 1.4.0
Development

Successfully merging a pull request may close this issue.

MXCrypto: Move decryptions out of the main thread matrix-org/matrix-ios-sdk
1 participant
@manuroe