Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the last message is redacted, [MXKRecentCellData update] makes paginations loops #520

Closed
manuroe opened this issue Aug 18, 2016 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#123
Closed

When the last message is redacted, [MXKRecentCellData update] makes paginations loops #520

manuroe opened this issue Aug 18, 2016 · 1 comment · Fixed by matrix-org/matrix-ios-sdk#123
Assignees
@manuroe
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
sprint2.2

Comments

@manuroe
Copy link
Member

manuroe commented Aug 18, 2016 •
edited
Loading

In a room where the last message is redacted like this:

MessageA
MessageB
MessageC
[redacted] (or profile change as we ignore them now)

[MXKRecentCellData update] does not use "MessageC" as the last message of the room but makes infinite paginations loops.
@manuroe manuroe self-assigned this Aug 19, 2016
@manuroe manuroe added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems P1 labels Aug 19, 2016
@manuroe
Copy link
Member Author

manuroe commented Aug 19, 2016

Labelled as P1 because the fix for #494 generates this issue a lot.

@giomfo giomfo added this to the sprint2.2 milestone Aug 22, 2016
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this issue Aug 24, 2016
@manuroe
BF: When the last message is redacted, [MXKRecentCellData update] mak…
e24b46a 
…es paginations loops element-hq/element-ios#520

Use the new MXEventsEnumerator from MatrixSDK to find the right last message to display.
This was referenced Aug 24, 2016
Merged
Merged
@manuroe manuroe closed this as completed Aug 24, 2016
langleyd pushed a commit that referenced this issue Mar 29, 2023
@Velin92
iOS: Replace NBSP with ZWSP to allow block rendering (#520)
3c4d457 
* close to the solution but still experiencing a misalignment

* partial fix for the end of the document

* replaceNewlinesWithDiscardableElements however it doesn't work properly yet

* improvements but the replace doesn't always work

* finally this works

* comment improvement

* code improvement, we only replace with zwsp when necessary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
sprint2.2
Development

Successfully merging a pull request may close this issue.

Add store events enumerator matrix-org/matrix-ios-sdk
2 participants
@manuroe @giomfo