Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS client does not support the dummy login flow #650

Closed
ylecollen opened this issue Sep 23, 2016 · 2 comments
Closed

iOS client does not support the dummy login flow #650

ylecollen opened this issue Sep 23, 2016 · 2 comments
Labels
feature P3 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@ylecollen
Copy link

1- the account creation is detected as not supported so the ios client offers to open the registration fallback but it fails

https://104.237.225.220:8448/_matrix/static/client/register/

2 - the IOS client does not support the dummy login flow

See
https://github.com/vector-im/vector-android/pull/550/files
To find the code update to fix this issue

3-
https://github.com/vector-im/vector-ios/blob/master/Vector/Views/Authentication/AuthInputsView.m#L795
it seems that a line is missing
----> return updatedAuthSession;
giomfo added a commit to matrix-org/matrix-ios-kit that referenced this issue Sep 26, 2016
@giomfo
MXKAuthInputs - Auth session validation: Keep only supported authenti…
c86d93a 
…cation flows.

element-hq/element-ios#650
giomfo added a commit that referenced this issue Sep 26, 2016
@giomfo
AuthInputsView - Session validation: Keep only supported authenticati…
02e18a8 
…on flows.

#650
@giomfo
Copy link
Member

giomfo commented Sep 26, 2016

The third point has been fixed

@giomfo giomfo changed the title Cannot create account on HS https://104.237.225.220:8448/ iOS client does not support the dummy login flow Sep 26, 2016
@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements feature P3 labels Sep 26, 2016
@giomfo
Copy link
Member

giomfo commented Feb 24, 2017

dup #912

@giomfo giomfo closed this as completed Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature P3 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giomfo @ylecollen