Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render sticker events in the timeline #1831

Merged
merged 3 commits into from
Apr 3, 2018
Merged

Render sticker events in the timeline #1831

merged 3 commits into from
Apr 3, 2018

Conversation

giomfo
Copy link
Member

@giomfo giomfo commented Apr 2, 2018

@giomfo
Render sticker events in the timeline #1819
e5bdce5 
Prepare sticker rendering
@giomfo
Render sticker events in the timeline
3e2533b 
- Display the sticker description when it is selected
TODO animate the sticker if possible

 #1819
@giomfo
Render sticker events in the timeline
9638de3 
- Code update
@giomfo giomfo requested a review from manuroe April 2, 2018 22:27
manuroe
manuroe approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@giomfo
Copy link
Member Author

giomfo commented Apr 3, 2018 •
edited

Here is the current rendering:
screen shot 2018-04-03 at 15 10 56

@giomfo giomfo merged commit 37754f0 into develop Apr 3, 2018
@giomfo giomfo deleted the riot_1819 branch April 3, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuroe manuroe manuroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giomfo @manuroe