RoomVC: Add a re-request keys button on message unable to decrypt #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBiOSoftWhare
approved these changes
Jun 12, 2018
The flow has changed a bit. #1879
|
Flow update: we make a re-request once the user taps on the link and we display the explanation modal in parallel. Modal content update: |
SBiOSoftWhare
suggested changes
Jun 12, 2018
| // Observe kMXEventDidDecryptNotification to remove automatically the dialog | ||
| // if the user has shared the keys from another device | ||
| id didDecryptObserver; | ||
| didDecryptObserver = [[NSNotificationCenter defaultCenter] addObserverForName:kMXEventDidDecryptNotification object:nil queue:[NSOperationQueue mainQueue] usingBlock:^(NSNotification *notif) { |
There was a problem hiding this comment.
You should store didDecryptObserver as instance variable and remove it from NSNotificationCenter in dealloc. Otherwise this observer block could never be removed if controller is deallocated and "ok" alert not tapped.
Take Steve's remark into account
SBiOSoftWhare
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1879
The wording in the modal is subject to change.