Replies: Implement sending #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nput placeholder when sending a reply.
… on timeline for supported events.
manuroe
reviewed
Jul 24, 2018
| // Check the device screen size before using large placeholder | ||
| BOOL shouldDisplayLargePlaceholder = [GBDeviceInfo deviceInfo].family == GBDeviceFamilyiPad || [GBDeviceInfo deviceInfo].displayInfo.display >= GBDeviceDisplay4p7Inch; | ||
|
|
||
| if (shouldDisplayLargePlaceholder) |
There was a problem hiding this comment.
should be if (!shouldDisplayLargePlaceholder), no?
| @@ -200,6 +200,8 @@ @interface RoomViewController () | |||
|
|
|||
| // Observe kRiotDesignValuesDidChangeThemeNotification to handle user interface theme change. | |||
| id kRiotDesignValuesDidChangeThemeNotificationObserver; | |||
|
|
|||
| BOOL isInReplyMode; | |||
There was a problem hiding this comment.
It probably worth to describe here what is this mode: If the user has selected a message, we are in this mode.
manuroe
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1911
Implement reply to an event with text message in a room. It is now possible to reply quickly to a message by highlighting it and then typing some text.