Use MXIdentityService to perform identity server requests #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBiOSoftWhare
requested review from
giomfo and
manuroe
and removed request for
giomfo
giomfo
reviewed
Aug 21, 2019
|
|
||
| // Create the next link that is common to all Vector.im clients | ||
| NSString *nextLink = [NSString stringWithFormat:@"%@/#/register?client_secret=%@&hs_url=%@&is_url=%@&session_id=%@", | ||
| [Tools webAppUrl], | ||
| [submittedEmail.clientSecret stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]], | ||
| [restClient.homeserver stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]], | ||
| [restClient.identityServer stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]], | ||
| [identityServer stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLHostAllowedCharacterSet]], |
There was a problem hiding this comment.
Caution: What should be done when this identityServer string is null? remove "is_url" from the path?
| @@ -626,7 +628,7 @@ - (void)prepareParameters:(void (^)(NSDictionary *parameters, NSError *error))ca | |||
| success:^ | |||
| { | |||
|
|
|||
| NSURL *identServerURL = [NSURL URLWithString:restClient.identityServer]; | |||
| NSURL *identServerURL = [NSURL URLWithString:identityServer]; | |||
There was a problem hiding this comment.
idem: I think you should handle the case where identityServer is null
giomfo
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2647
Requires matrix-org/matrix-ios-sdk/pull/706 & matrix-org/matrix-ios-kit/pull/592