Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification by DM: Support QR code #3030

Merged
merged 24 commits into from
Mar 17, 2020
Merged

Verification by DM: Support QR code #3030

merged 24 commits into from
Mar 17, 2020

Conversation

SBiOSoftWhare
Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare commented Mar 13, 2020

Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, so good.

private func presentQRCodeReader(animated: Bool) {
let qrCodeViewController = QRCodeReaderViewController.instantiate()
qrCodeViewController.delegate = self
self.present(qrCodeViewController, animated: animated, completion: nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better from an architecture point of view to present if from a coordinator?

self.activityPresenter.presentActivityIndicator(on: self.view, animated: true)
}

private func renderLoaded(viewData: KeyVerificationVerifyByScanningViewData) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should display a better screen if the verification is SAS only:
Simulator Screen Shot - iPhone Xs - 2020-03-16 at 15 43 34

@SBiOSoftWhare SBiOSoftWhare merged commit 7a6f41e into develop Mar 17, 2020
@SBiOSoftWhare SBiOSoftWhare deleted the riot_2921 branch March 17, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants