Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story] View expanded map #1678

Closed
9 tasks done
Tracked by #1525
Johennes opened this issue May 16, 2023 · 4 comments
Closed
9 tasks done
Tracked by #1525

[Story] View expanded map #1678

Johennes opened this issue May 16, 2023 · 4 comments
Assignees
@csmith @alfogrillo
Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA

Comments

@Johennes
Copy link
Contributor

Johennes commented May 16, 2023 •
edited by callumu
Loading

  • As a user
  • I want to expand a map view in the timeline
  • so that I can inspect the surroundings of the location

Size estimate

S

Dependencies

Acceptance criteria

  • Tapping a map view in the timeline expands it
  • The expanded map view shows the map provider's copyright attribution
  • The expanded map view can be panned and zoomed
  • Default zoom level: 15
  • The share button opens the system sharing dialog for the location
  • View the description of the location event (if it is not empty)
    • Show (if any) below the nav bar as in the design
  • Analytics tracking
    • When showing the sending map view
      • Event: $screen
      • Property: screenName = LocationView

Out of scope

Sign-off

Android

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

iOS

  • Design sign-off on completion
  • QA sign-off on completion
  • Product sign-off on completion

Subtasks

Android
Beta Give feedback
  1. [Story] View expanded map vector-im/element-x-android#741
    csmith
  2. Location expanded view: show own location vector-im/element-x-android#916
    julioromano
  3. Add screenshots with ~1.5 lines long desc to expanded location view vector-im/element-x-android#923
    julioromano
  4. Pixel perfect static images vector-im/element-x-android#933
    julioromano
  5. Show location request permission in expanded location view vector-im/element-x-android#963
    julioromano

iOS
Beta Give feedback
  1. View expanded map from timeline vector-im/element-x-ios#1182
    A-Location T-Enhancement Team: Element X Feature
    alfogrillo
  2. Add location related analytics vector-im/element-x-ios#1241
    alfogrillo
  3. Update "user's location" dot color vector-im/element-x-ios#1354
    alfogrillo

Other
Beta Give feedback
  1. Map MSC3488 fields for UniFFI matrix-org/matrix-rust-sdk#2187
    alfogrillo
@Johennes Johennes mentioned this issue May 16, 2023
Closed
1 task
@Johennes Johennes changed the title View maximised map [Story] View maximised map May 16, 2023
@Johennes Johennes mentioned this issue May 16, 2023
Closed
6 tasks
@Johennes Johennes changed the title [Story] View maximised map [Story] View expanded map May 16, 2023
@Johennes Johennes mentioned this issue May 17, 2023
Closed
6 tasks
@alfogrillo alfogrillo self-assigned this Jun 26, 2023
@alfogrillo alfogrillo mentioned this issue Jun 27, 2023
Closed
@csmith csmith mentioned this issue Jun 30, 2023
Closed
@Johennes Johennes mentioned this issue Jul 4, 2023
Closed
6 tasks
@Johennes
Copy link
Contributor Author

@julioromano in the review today we've found that the pin is too big in the expanded map and you said this might already be fixed. Could you verify that and if it is fix, set the Android status of this story to "Reviewed"?

@julioromano julioromano mentioned this issue Jul 19, 2023
Merged
@julioromano
Copy link
Contributor

It is fixed. But we're still missing on android this too element-hq/element-x-android#916

julioromano added a commit to element-hq/element-x-android that referenced this issue Jul 19, 2023
@julioromano
Location expanded view: show own location (#916)
4162d16 
If the location permission is granted:
- Shows the user's own location
- Shows a button to center the map on it

Part of:
- element-hq/element-meta#1678
@julioromano
Copy link
Contributor

It is fixed. But we're still missing on android this too vector-im/element-x-android#916

It's now been merged but technically it's not been reviewed.

@julioromano julioromano mentioned this issue Jul 19, 2023
Merged
@Johennes
Copy link
Contributor Author

Ok, thanks. I'll put this on the agenda for review again in the next weekly.

This was referenced Jul 20, 2023
Merged
Merged
julioromano added a commit to element-hq/element-x-android that referenced this issue Jul 20, 2023
@julioromano
Add screenshots with ~1.5 lines long desc to expanded location view (#…
c746981 
…923)

This will help in catching alignment regressions.

Related to:
- element-hq/element-meta#1678
julioromano added a commit to element-hq/element-x-android that referenced this issue Jul 20, 2023
@julioromano
Use correct share my location icon in button (#936)
d964650 
As per newer design specs.

Related to:
- element-hq/element-meta#1678
julioromano added a commit to element-hq/element-x-android that referenced this issue Jul 21, 2023
@julioromano
Static images improvements (#933)
57d04e4 
1. On devices less than xhdpi request a 1x image from MapTiler (such devices are generally old, slower and with little memory so avoiding to get the 2x image only to have to shrink it later could help).
2. Coerce too big width/height combos within the API limits keeping the aspect ratio (this will allow requests on big horizontal displays to succeed).
3. Don't crash when given weird width/height combos (i.e. zero or negative).
4. Introduce interfaces to hide this whole logic and make it easier for forks to implement their own.

Related to:
- element-hq/element-meta#1678
@julioromano julioromano mentioned this issue Jul 26, 2023
Merged
@langleyd langleyd added the X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA label Sep 19, 2023
@kittykat kittykat closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csmith csmith

@alfogrillo alfogrillo

Labels
App: ElementX Android App: ElementX iOS T-User Story Team: Element X Feature X-Needs-Signoff Stories and Epics which are ready for review by product, design and QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kittykat @csmith @Johennes @julioromano @langleyd @alfogrillo