Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Show a user has been mentioned in the timeline #2062

Closed
6 tasks done
VolkerJunginger opened this issue Sep 22, 2023 · 1 comment
Closed
6 tasks done

[Story] Show a user has been mentioned in the timeline #2062

VolkerJunginger opened this issue Sep 22, 2023 · 1 comment

Comments

@VolkerJunginger
Copy link
Contributor

VolkerJunginger commented Sep 22, 2023

Story

As a user that i looking at a message containing a mention I want to understand that this is a mention.

Figma link: TBD

Acceptance criteria

  • Resolve a mention into a "pill" design.
  • Show the avatar and the name of the mentioned user

Size estimate

M

Subtasks

Android

  1. A-Timeline T-Enhancement
    jmartinesp
  2. A-Timeline T-Enhancement

iOS

  1. A-Pills A-Timeline T-Enhancement
  2. A-Pills T-Enhancement X-Needs-Design

Rust

  1. A-Notification A-Room-List A-Timeline X-Needs-Rust Z-Schedule
    Velin92

Design

  • QA signoff on completion
  • Design signoff on completion
  • Product signoff on completion
@Velin92
Copy link

Velin92 commented Sep 26, 2023

Currently working on this, however there are no designs ready so the initial implementation will be a bit improvised.

Also since there is a loading state (since we lazily fetch the members) for some very big rooms the display name and the avatar of the suer are not ready yet, this only happens in very very big rooms, and is usually unnoticeable, however as of right now I am implementing a loading state for the mention that looks like this:
Screenshot 2023-09-26 at 16 20 02

Colors and design not final, this is just essentially displaying a placeholder of a @ with the user ID, this can of course be changed later if design wants, as I said is very unlikely to get into this condition

NOTE: This is also the El-Web default behaviour when a matrix user mention is done for a user that is not in the room

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants