Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Intentional Mentions (MSC3952) on Mobile #1516

Open
2 of 5 tasks
daniellekirkwood opened this issue Apr 25, 2023 · 8 comments
Open
2 of 5 tasks

Implement Intentional Mentions (MSC3952) on Mobile #1516

daniellekirkwood opened this issue Apr 25, 2023 · 8 comments

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Apr 25, 2023

Your use case

MSC3952 is nearly out of FCP. Once completed we will need to implement and stabilise it.

For cross-linking (originally from #886 (comment)):

@daniellekirkwood
Copy link
Contributor Author

@giomfo Created this 'holding' issue based on our conversation today (before I forget). I will add more to it tomorrow

@daniellekirkwood daniellekirkwood self-assigned this Apr 25, 2023
@clokep
Copy link
Contributor

clokep commented Apr 25, 2023

@daniellekirkwood I filed matrix-org/synapse#15487 for the Synapse side.

@daniellekirkwood
Copy link
Contributor Author

This doesn't need to be on the WAT board anymore -- @Johennes & @clokep did we get the Synapse and EleWeb side of this sorted? Should I move it to a mobile only issue and assign to the right folks?

@Johennes
Copy link
Contributor

There is nothing left to do on the Element Web side AFAIK.

@clokep
Copy link
Contributor

clokep commented Oct 16, 2023

did we get the Synapse and EleWeb side of this sorted?

Synapse supports it, as does Element Web & its components. It would be nice to finish off support for Matrix 1.7 in Synapse so clients are able to easily see this is supported, but it is not a requirement since clients can see the push rule and key off that.

Should I move it to a mobile only issue and assign to the right folks?

For cross-linking (originally from #886 (comment)):

@daniellekirkwood daniellekirkwood changed the title Implement MSC3952 Implement Intentional Mentions (MSC3952) on Mobile Oct 17, 2023
@daniellekirkwood
Copy link
Contributor Author

@manuroe @giomfo @VolkerJunginger

We've done most of what we need on the server and web side here so I've updated the task to be an EX one. Let us know if you have questions, otherwise we'll leave this to prioritise on your roadmap. Thanks.

@giomfo
Copy link
Member

giomfo commented Oct 18, 2023

@manuroe @langleyd FYI the intentional mentions (MSC3952) has been taken into account when we "Expose the push notification settings #1959" in Rust SDK. Some updates have been applied on this implementation to improve it like this PR.
I consider EX is ready to support MSC3952 - You may double check with EX Feature team
About Legacy Element mobile clients, nothing has been done, the mention handling would depend only on the legacy push rules. I think the new push rules are ignored by default on these clients.

@manuroe
Copy link
Member

manuroe commented Oct 18, 2023

The platform team is on it, assembling the different pieces made by other teams. Thanks all!

I edited the issue with user stories that cover intentional mentions on EX mobile. They are part of the broader [Epic] Mentions that will make mentions work for real even in E2EE rooms!

@daniellekirkwood daniellekirkwood removed their assignment Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants