Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megolm Backup | Client should always have a local copy of all their megolm keys to limit the possibility of key loss #2446

Open
5 tasks
BillCarsonFr opened this issue Jun 18, 2024 · 2 comments

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Jun 18, 2024

Context

We implemented a recent change to the way we get the room keys from backup. Previously, the full backup was downloaded after verification, as soon as the backup decryption key was known, but that did not result in a good user experience when your backup was too big. The time to download the full backup and decrypt it could be taking 10s of minutes depending on the platform.

In order to improve that (and in the absence of pagination for the backup), keys are now downloaded on-demand when we try to decrypt an historical message.
This results in a better user experience, as the messages get decrypted faster after a new login.

Problem

With this new way of getting the keys, all user sessions will now have only a partial set of the backed up keys. This can cause key loss if for example a user tries to reset his backup (without importing first from the previous backup).

Notice that the previous implementation of full backup import has several issues:

  • Performance
  • Lack of pause/stop/resume. Particularly on mobile, if the app was put in background and terminated by the OS before the end of import, it was not restarted.
  • Was possible to start several import in parallel

Solution

We want to ensure that each new client gets a copy of all the keys in backup as soon as it can. The operation should be resilient to app restart and should have an API [richvdh: or, more to the point: a UI?] to report progress.

  • EAX/EIX:
    • rust-sdk: Ensure that all the keys from a given backup version are downloaded
    • EIX: UI feedback for ongoing import
    • EAX: UI feedback for ongoing import

Related/Existing issues

@richvdh
Copy link
Member

richvdh commented Jun 26, 2024

I wrote some notes on how we might do this for web at element-hq/element-web#27009.

Notes:

  • In a naive implementation, if the app is killed during the recovery, we'll restart from the beginning next time. Anything else is somewhat annoying without a fix to Key backup restore API lacks sensible pagination #2176.
  • If your backup is too big, it's possible that we'll never successfully download it; the client will just keep retrying.

@richvdh
Copy link
Member

richvdh commented Jun 26, 2024

Question: is there any value in attempting to download individual keys on-demand once the full backup has been successfully downloaded? I'd think not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants