Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message Bubbles #72

Closed
daniellekirkwood opened this issue Dec 15, 2021 · 7 comments
Closed

Message Bubbles #72

daniellekirkwood opened this issue Dec 15, 2021 · 7 comments
Assignees
@jakewb-b @daniellekirkwood
Labels
A-Message-Bubbles T-Epic Issue is at Epic level Z-Labs

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 15, 2021 •
edited by pmaier1
Loading

We're delivering Message Bubbles for a customer and for users.

Bubbles Project Board

Milestone 1 (Build & Labs flags)

Implement Bubbles across all 3 platforms

Rounds of Testing (Sheet here) completed and passed

Deliver Bubbles for users and customers

Milestone 2 (Flexibility)

  • Make Bubbles appearance flexible (E.G.: Only in DMs, per Space, etc.)
  • Update Emote Bubble type
@daniellekirkwood daniellekirkwood self-assigned this Dec 15, 2021
@daniellekirkwood
Copy link
Contributor Author

daniellekirkwood commented Dec 15, 2021 •
edited
Loading

To Bubble, or not to Bubble:

Event/Message Type To Bubble, or not to Bubble? Web Android iOS
State events: List of state events No state events in Bubbles. -- -- --
Timeline events: -- -- -- --
Redaction No
Sticker No, not in a Bubble element-hq/element-web#20523 element-hq/element-android#4965 element-hq/element-ios#5388
Call No Bubble, centred element-hq/element-web#20324
Poll No Bubble, centred on Mobile
We had to make the call to temporarily have Polls in Bubbles on Mobile due to time constraints		 Done element-hq/element-android#4576 element-hq/element-ios#5210
Message: -- -- -- --
Text Yes, in a Bubble Done element-hq/element-android#4574 element-hq/element-ios#5208
Emote No, not in a bubble element-hq/element-web#20617 -- --
Notice TBD Need to see this msg type for decision
Image (media) No Bubble; Needs timestamp and gradient element-hq/element-web#20326 element-hq/element-android#4575 element-hq/element-ios#5209
File (media) No Bubble element-hq/element-web#20326 element-hq/element-android#4575 element-hq/element-ios#5209
Audio (media) No Bubble element-hq/element-web#20326 element-hq/element-android#4575 element-hq/element-ios#5209
Location (media) No Bubble element-hq/element-web#20323 element-hq/element-android#4575 element-hq/element-ios#5209
Video (media) No Bubble element-hq/element-web#20326 element-hq/element-android#4575 element-hq/element-ios#5209
E2E Verification TBD Need to see this msg type for decision
Replies Yes , in a Bubble Done element-hq/element-android#4583 element-hq/element-ios#5213
Quotes Yes, in a Bubble Done element-hq/element-android#4580 element-hq/element-ios#5215
URL previews No Bubble Done element-hq/element-android#4579 element-hq/element-ios#5212
Code blocks Yes, in a Bubble Done element-hq/element-android#4574
Thread Summary No Bubble element-hq/element-web#20419 element-hq/element-android#4870 element-hq/element-ios#5348
Thread Messages Yes, in Thread panel timeline element-hq/element-web#20419 element-hq/element-android#4870 element-hq/element-ios#5348
Emoji Reaction Not in bubble Done element-hq/element-android#4582 element-hq/element-ios#5214
Read receipts Not in bubble Done No bubbles change needed (see comment below) No bubbles change needed (see comment below)

@daniellekirkwood
Copy link
Contributor Author

daniellekirkwood commented Dec 15, 2021 •
edited
Loading

List of State Events:
Canonical Alias (#matrix:matrix.org), Join Rules (public, private etc), Member (membership, displayname change etc), 3PID invite (invite to email address), Permissions (PL) change, Room Name, Room Topic, Room Avatar, Change pinned events (labs), Encryption enabled, History visibility, Guest access, Server ACLs, Tombstone, Manage widgets, Hidden/Unknown events (development mode)

@daniellekirkwood daniellekirkwood changed the title Chat Bubbles MVP Message Bubbles Dec 23, 2021
@daniellekirkwood daniellekirkwood added the T-Epic Issue is at Epic level label Jan 11, 2022
@daniellekirkwood
Copy link
Contributor Author

daniellekirkwood commented Jan 11, 2022 •
edited
Loading

Other improvements to make as a part of Bubbles work

These do not Block the release of Bubbles

Message type Web Android iOS
Reactions element-hq/element-android#4674
element-hq/element-android#3344		 element-hq/element-ios#5370
Replies element-hq/element-android#3703 Don't think any change is needed here
Read receipts No change for V1
element-hq/element-android#4915		 No change for V1
element-hq/element-ios#5371
Files element-hq/element-android#4897 element-hq/element-ios#5372

This was referenced Jan 18, 2022
Closed
Closed
@daniellekirkwood
Copy link
Contributor Author

Emote issue: element-hq/element-web#20322

@daniellekirkwood
Copy link
Contributor Author

Polls go in a bubble on Mobile as they take the whole width of the screen and without the bubble it is not clear who sent it the message...

@daniellekirkwood
Copy link
Contributor Author

Emotes are staying in a Bubble on iOS due to how long it will take to move them out. They should be moved out of bubbles once the timeline has been refactored

@daniellekirkwood daniellekirkwood mentioned this issue Mar 7, 2022
Closed
@github-actions github-actions bot added the Z-Labs label Mar 7, 2022
@daniellekirkwood
Copy link
Contributor Author

Bubbles are no longer in Labs on iOS so moving this issue to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakewb-b jakewb-b

@daniellekirkwood daniellekirkwood

Labels
A-Message-Bubbles T-Epic Issue is at Epic level Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakewb-b @daniellekirkwood