Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please reinstate the ability to react with non-unicode keys #10256

Closed
Cadair opened this issue Jul 4, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#3186
Closed

Please reinstate the ability to react with non-unicode keys #10256

Cadair opened this issue Jul 4, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#3186
Assignees
@jryans
Labels
A-Aggregations A-Reactions T-Enhancement

Comments

@Cadair
Copy link

Cadair commented Jul 4, 2019 •
edited
Loading

A recent change seem to have been to not display any reaction events which don't have a single (unicode?) character as a reaction key.

Please consider reversing this. I am working on bridging reactions to slack (matrix-org/matrix-appservice-slack#131) and I had implemented bridging custom emoji from slack to matrix using just the short code, so the reaction would come across into matrix as :partyparrot: or whatever. This, while being much more ugly in comparison to the actual custom emoji, at least allows the information that people have reacted with that custom emoji to come over into matrix, until we get our own custom emoji implementation.

I understand the desire to restrict the reaction field (as fun as it is to react with 64K of text), but can we loosen it a little to maybe 20 characters or something?
@Half-Shot
Copy link
Member

Agreed. There is merit to being able to react with shortcodes from a bridging PoV.

@f0x52
Copy link

f0x52 commented Jul 4, 2019

I think you could also (ab)use text reactions to have an in-line way to communicate with a bot, which will listen for reactions to do certain actions

@jryans jryans added feature A-Aggregations A-Reactions X-Needs-Product More input needed from the Product team labels Jul 4, 2019
@tulir
Copy link
Contributor

tulir commented Jul 4, 2019

Buttons (matrix-org/matrix-doc#1485 / matrix-org/matrix-react-sdk#2109 or something) would provide a better solution for @f0x52's use case (which is also my use case), but from a reaction bridging PoV I definitely support text reactions being allowed too.

@lampholder lampholder added phase:2 and removed X-Needs-Product More input needed from the Product team labels Jul 4, 2019
@ara4n
Copy link
Member

ara4n commented Jul 4, 2019

this is getting fixed. but we're drawing the line at anything longer than :partyparrot:

@Cadair
Copy link
Author

Cadair commented Jul 4, 2019

Oh! Now I wish I had considered my example more carefully 😛

(:partyparrot: is 13 characters, 20 seems reasonable?)

@Half-Shot
Copy link
Member

@Cadair surely we just need to whitelist every shortcode used by Slack :) /s

This was referenced Jul 5, 2019
Closed
Closed
@jryans jryans self-assigned this Jul 5, 2019
@jryans jryans added this to In Progress in Web App Team via automation Jul 5, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 5, 2019
@jryans
Allow diplayed reaction values to contain anything
2a8f9a8 
Part of element-hq/element-web#10256
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 5, 2019
@jryans
Clamp reaction content width to at most 100px
eb0e1ea 
Part of element-hq/element-web#10256
@jryans jryans mentioned this issue Jul 5, 2019
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Jul 5, 2019
Web App Team automation moved this from In Review to In Test Jul 5, 2019
@jryans jryans moved this from In Test to Done in Web App Team Jul 18, 2019
@jryans jryans removed the feature label Mar 5, 2021
su-ex added a commit to SchildiChat/element-web that referenced this issue Mar 15, 2023
@su-ex
Merge tag 'v1.11.25' into sc
a35f6cb 
* Remove experimental PWA support for Firefox and Safari ([\element-hq#24630](element-hq#24630)).
* Only allow to start a DM with one email if encryption by default is enabled ([\element-hq#10253](matrix-org/matrix-react-sdk#10253)). Fixes element-hq#23133.
* DM rooms are now encrypted if encryption by default is enabled and only inviting a single email address. Any action in the result DM room will be blocked until the other has joined. ([\element-hq#10229](matrix-org/matrix-react-sdk#10229)).
* Reduce bottom margin of ReplyChain on compact modern layout ([\element-hq#8972](matrix-org/matrix-react-sdk#8972)). Fixes element-hq#22748. Contributed by @luixxiul.
* Support for v2 of MSC3903 ([\element-hq#10165](matrix-org/matrix-react-sdk#10165)). Contributed by @hughns.
* When starting a DM, existing rooms with pending third-party invites will be reused. ([\element-hq#10256](matrix-org/matrix-react-sdk#10256)). Fixes element-hq#23139.
* Polls push rules: synchronise poll rules with message rules ([\element-hq#10263](matrix-org/matrix-react-sdk#10263)). Contributed by @kerryarchibald.
* New verification request toast button labels ([\element-hq#10259](matrix-org/matrix-react-sdk#10259)).
* Remove padding around integration manager iframe ([\#10148](matrix-org/matrix-react-sdk#10148)).
* Fix block code styling in rich text editor ([\element-hq#10246](matrix-org/matrix-react-sdk#10246)). Contributed by @alunturner.
* Poll history: fetch more poll history ([\element-hq#10235](matrix-org/matrix-react-sdk#10235)). Contributed by @kerryarchibald.
* Sort short/exact emoji matches before longer incomplete matches ([\element-hq#10212](matrix-org/matrix-react-sdk#10212)). Fixes element-hq#23210. Contributed by @grimhilt.
* Poll history: detail screen ([\element-hq#10172](matrix-org/matrix-react-sdk#10172)). Contributed by @kerryarchibald.
* Provide a more detailed error message than "No known servers" ([\element-hq#6048](matrix-org/matrix-react-sdk#6048)). Fixes element-hq#13247. Contributed by @aaronraimist.
* Say when a call was answered from a different device ([\element-hq#10224](matrix-org/matrix-react-sdk#10224)).
* Widget permissions customizations using module api ([\element-hq#10121](matrix-org/matrix-react-sdk#10121)). Contributed by @maheichyk.
* Fix copy button icon overlapping with copyable text ([\element-hq#10227](matrix-org/matrix-react-sdk#10227)). Contributed by @Adesh-Pandey.
* Support joining non-peekable rooms via the module API ([\element-hq#10154](matrix-org/matrix-react-sdk#10154)). Contributed by @maheichyk.
* The "new login" toast does now display the same device information as in the settings. "No" does now open the device settings. "Yes, it was me" dismisses the toast. ([\element-hq#10200](matrix-org/matrix-react-sdk#10200)).
* Do not prompt for a password when doing a „reset all“ after login ([\element-hq#10208](matrix-org/matrix-react-sdk#10208)).
* Fix incorrect copy in space creation flow ([\element-hq#10296](matrix-org/matrix-react-sdk#10296)). Fixes element-hq#24741.
* Fix space settings dialog having rogue title tooltip ([\element-hq#10293](matrix-org/matrix-react-sdk#10293)). Fixes element-hq#24740.
* Show spinner when starting a DM from the user profile (right panel) ([\element-hq#10290](matrix-org/matrix-react-sdk#10290)).
* Reduce height of toggle on expanded view source event ([\element-hq#10283](matrix-org/matrix-react-sdk#10283)). Fixes element-hq#22873. Contributed by @luixxiul.
* Pillify http and non-prefixed matrix.to links ([\element-hq#10277](matrix-org/matrix-react-sdk#10277)). Fixes element-hq#20844.
* Fix some features not being configurable via `features` ([\element-hq#10276](matrix-org/matrix-react-sdk#10276)).
* Fix starting a DM from the right panel in some cases ([\element-hq#10278](matrix-org/matrix-react-sdk#10278)). Fixes element-hq#24722.
* Align info EventTile and normal EventTile on IRC layout ([\element-hq#10197](matrix-org/matrix-react-sdk#10197)). Fixes element-hq#22782. Contributed by @luixxiul.
* Fix blowout of waveform of the voice message player on narrow UI ([\element-hq#8861](matrix-org/matrix-react-sdk#8861)). Fixes element-hq#22604. Contributed by @luixxiul.
* Fix the hidden view source toggle on IRC layout ([\element-hq#10266](matrix-org/matrix-react-sdk#10266)). Fixes element-hq#22872. Contributed by @luixxiul.
* Fix buttons on the room header being compressed due to long room name ([\element-hq#10155](matrix-org/matrix-react-sdk#10155)). Contributed by @luixxiul.
* Use the room avatar as a placeholder in calls ([\element-hq#10231](matrix-org/matrix-react-sdk#10231)).
* Fix calls showing as 'connecting' after hangup ([\element-hq#10223](matrix-org/matrix-react-sdk#10223)).
* Prevent multiple Jitsi calls started at the same time ([\element-hq#10183](matrix-org/matrix-react-sdk#10183)). Fixes element-hq#23009.
* Make localization keys compatible with agglutinative and/or SOV type languages ([\element-hq#10159](matrix-org/matrix-react-sdk#10159)). Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Reactions T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow diplayed reaction values to contain anything matrix-org/matrix-react-sdk
7 participants
@jryans @ara4n @Cadair @lampholder @Half-Shot @tulir @f0x52