Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature flags for reactions and edits #10282

Closed
jryans opened this issue Jul 8, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3233
Closed

Remove feature flags for reactions and edits #10282

jryans opened this issue Jul 8, 2019 · 4 comments · Fixed by matrix-org/matrix-react-sdk#3233
Assignees
@jryans
Labels
A-Aggregations A-Message-Editing A-Reactions T-Enhancement X-Release-Blocker

Comments

@jryans
Copy link
Collaborator

jryans commented Jul 8, 2019

Once we're confident that reactions and edits are stable, we can remove the feature flags.
@jryans jryans changed the title Remove feature flags for reactions and edits Remove feature flags and unstable URLs for reactions and edits Jul 10, 2019
@jryans
Copy link
Collaborator Author

jryans commented Jul 10, 2019

We've decided it's best to handle both feature flags and unstable URLs together: a feature should be allowed to use to unstable APIs while it has a feature flag, but it should change to specced and versioned APIs when the flags are removed.

@bwindels
Copy link
Contributor

Seems like quite a bit away from being able to do this, with backend and spec work stalled. Removing phase tag for now.

@bwindels bwindels removed the phase:3 label Jul 15, 2019
@jryans jryans changed the title Remove feature flags and unstable URLs for reactions and edits Remove feature flags for reactions and edits Jul 17, 2019
@jryans
Copy link
Collaborator Author

jryans commented Jul 17, 2019

Reducing scope back down to just the feature flags. It turns out that we don't have a clear system to keep a feature flag in the code and default it on without config work for deployments, so it's best to remove the flags now to get the features out to everyone.

Filed a new issue #10361 for the future work around unstable URLs.

@jryans jryans added the phase:2 label Jul 17, 2019
@jryans jryans self-assigned this Jul 17, 2019
@jryans jryans added this to In Progress in Web App Team via automation Jul 17, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2019
@jryans
Remove editing feature flag
674f339 
Part of element-hq/element-web#10282
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 17, 2019
@jryans
Remove reactions feature flag
599c496 
Fixes element-hq/element-web#10282
@jryans jryans mentioned this issue Jul 17, 2019
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Jul 17, 2019
Web App Team automation moved this from In Review to In Test Jul 18, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 18, 2019
@jryans
Remove editing feature flag
25351d5 
Part of element-hq/element-web#10282
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 18, 2019
@jryans
Remove reactions feature flag
537eb2c 
Fixes element-hq/element-web#10282
@jryans
Copy link
Collaborator Author

jryans commented Jul 18, 2019

Merged to React SDK 1.4.0 release branch in matrix-org/matrix-react-sdk#3233

jryans added a commit that referenced this issue Jul 18, 2019
@jryans
Remove edits feature flag from docs and config
7731f93 
Part of #10282
jryans added a commit that referenced this issue Jul 18, 2019
@jryans
Remove reactions feature flag from docs and config
8398ec5 
Part of #10282
@jryans jryans mentioned this issue Jul 18, 2019
Merged
jryans added a commit that referenced this issue Jul 18, 2019
@jryans
Remove edits feature flag from docs and config
b403828 
Part of #10282
jryans added a commit that referenced this issue Jul 18, 2019
@jryans
Remove reactions feature flag from docs and config
06ce10b 
Part of #10282
@jryans jryans moved this from In Test to Done in Web App Team Jul 18, 2019
@Esras Esras mentioned this issue May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Aggregations A-Message-Editing A-Reactions T-Enhancement X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove feature flags for reactions and edits matrix-org/matrix-react-sdk
2 participants
@bwindels @jryans