Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable DMs proof of concept salvage #10416

Closed
turt2live opened this issue Jul 25, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3286
Closed

Immutable DMs proof of concept salvage #10416

turt2live opened this issue Jul 25, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3286
Assignees
@turt2live
Labels
A-Immutable-DMs P1 T-Enhancement

Comments

@turt2live
Copy link
Member

Implementing the draft of #10415 to see how bad it can be.
@turt2live turt2live self-assigned this Jul 25, 2019
@turt2live turt2live added this to In Progress in Web App Team via automation Jul 25, 2019
@turt2live turt2live mentioned this issue Jul 26, 2019
Closed
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 26, 2019
@turt2live
Start using new direct chats stuff when possible (or leave a reminder)
ff2fd38 
For element-hq/element-web#10416

TODO comments should largely explain what (isn't) there.
@turt2live turt2live mentioned this issue Jul 26, 2019
Closed
4 tasks
@turt2live
Copy link
Member Author

turt2live commented Jul 30, 2019 •
edited
Loading

The existing PoC needs altering to handle the server-side bits. There's parts of it which might be able to split out as benefits anyways (removal of ChatReuseDialog). See matrix-org/matrix-spec-proposals#2199

Edit: blocking on further MSC work to solidify it, then minor server work to get everything going.

@jryans jryans removed this from In Progress in Web App Team Jul 30, 2019
@turt2live turt2live changed the title Immutable DMs proof of concept Immutable DMs proof of concept salvage Aug 7, 2019
@turt2live turt2live added this to In Progress in Web App Team via automation Aug 7, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 7, 2019
@turt2live
Reuse direct chats when starting new ones
2ecabd2 
Part of element-hq/element-web#10416

This section of code applies to the + button next to PEOPLE in the room list.
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 7, 2019
@turt2live
Disable 'Start New Chat' button in MemberInfo if we already have chats
3144b9f 
Part of element-hq/element-web#10416
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 7, 2019
@turt2live
Replace DM logic in view_start_chat_or_reuse
24705d0 
Part of element-hq/element-web#10416

This code is used by the welcome bot logic and the groups/communities section of the app. goHomeOnCancel can be removed because no matter what happens we'll end up in a room with the user (and we aren't showing a dialog anymore).
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 7, 2019
@turt2live
Remove ChatCreateOrReuseDialog
238716e 
Part of element-hq/element-web#10416

All usages of the dialog have been replaced with new DM logic.
@turt2live turt2live mentioned this issue Aug 7, 2019
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 7, 2019
@turt2live
Remove ChatCreateOrReuseDialog
f85898c 
Part of element-hq/element-web#10416

All usages of the dialog have been replaced with new DM logic.
@turt2live turt2live moved this from In Progress to In Review in Web App Team Aug 7, 2019
Web App Team automation moved this from In Review to In Test Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Immutable-DMs P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse DMs whenever possible instead of asking to reuse them matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live