Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Composer: Round trip through editing is not consistent. #10725

Open
michaelkaye opened this issue Sep 2, 2019 · 3 comments
Open

New Composer: Round trip through editing is not consistent. #10725

michaelkaye opened this issue Sep 2, 2019 · 3 comments
Labels
A-Composer A-Message-Editing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@michaelkaye
Copy link
Contributor

michaelkaye commented Sep 2, 2019

Description

Round tripping through the composer and edit window is not consistent:

_italic_ -> *italic*

> quote ->

>
quote

***both*** -> *both* #! this has lost the bolding. -> #17610

While I understand that some of these are synonyms for each other, it's a bit confusing that the examples don't line up with how the composer re-renders text.

Steps to reproduce

Type this in the edit window per instructions in the reallysmalltext
round_trip1
Send this:
round_trip2
Edit it and get this?
round_trip3

Version information

  • Platform: web

For the web app:

  • Browser: Firefox 68
  • OS: Linux
  • URL: riot.im/develop
@ara4n
Copy link
Member

ara4n commented Sep 2, 2019

related: #10722

@MadLittleMods
Copy link
Contributor

The orignal example just happens to work now _italic_ -> *italic* ✅ but the opposite doesn't *italic* -> _italic_

The > quote example is also still relevant.

The both italic and bold problem is separately being tracked by #17610 and was also reported in #11477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Message-Editing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants