Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-compact list turned into compact list when editing a sent message #22863

Closed
Flupp opened this issue Jul 15, 2022 · 4 comments
Closed

non-compact list turned into compact list when editing a sent message #22863

Flupp opened this issue Jul 15, 2022 · 4 comments
Assignees
Labels
A-Composer A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@Flupp
Copy link

Flupp commented Jul 15, 2022

Steps to reproduce

Send a message containing a non-compact list:

A list:

- item 1

- item 2

Then click on the edit button for that message.

Outcome

What did you expect?

Markdown source with a non-compact list:

A list:

- item 1

- item 2

What happened instead?

Markdown source with a compact list:

A list:

- item 1
- item 2

Note that compact and non-compact lists are rendered differently.

Although already closed, issues #20073 and #13474 might be related.

Operating system

Arch Linux

Application version

element-desktop 1.11.0-1

How did you install the app?

Pacman / official Arch Linux repositories

Homeserver

No response

Will you send logs?

No

@Flupp Flupp added the T-Defect label Jul 15, 2022
@robintown
Copy link
Member

Regressed by matrix-org/matrix-react-sdk#8004

@robintown robintown added X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Message-Editing A-Composer O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jul 15, 2022
@andybalaam
Copy link
Contributor

andybalaam commented Jul 21, 2022

Hopefully if we'd written the right test in matrix-react-sdk/test/editor/roundtrip-test.ts we would have caught this - when we fix it I suggest adding one (if I'm right).

@robintown
Copy link
Member

We actually used to have a test for this in test/editor/deserialize-test.js, but I removed it in that PR because the syntax it expected still didn't actually parse as a non-tight list under Commonmark

@t3chguy
Copy link
Member

t3chguy commented Nov 2, 2022

Duplicate of #10725

@t3chguy t3chguy marked this as a duplicate of #10725 Nov 2, 2022
@t3chguy t3chguy closed this as completed Nov 2, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

4 participants