Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluebird 3.6.0+ causes NS_ERROR_NOT_INITIALIZED errors in Firefox #11148

Closed
jryans opened this issue Oct 16, 2019 · 1 comment · Fixed by matrix-org/matrix-js-sdk#1055
Closed

Bluebird 3.6.0+ causes NS_ERROR_NOT_INITIALIZED errors in Firefox #11148

jryans opened this issue Oct 16, 2019 · 1 comment · Fixed by matrix-org/matrix-js-sdk#1055
Assignees
@jryans
Labels
P1 T-Defect X-Regression

Comments

@jryans
Copy link
Collaborator

jryans commented Oct 16, 2019

As part of matrix-org/matrix-js-sdk#1053, one of the deps we upgraded was Bluebird from 3.5.5 to 3.7.0.

It turns out that 3.6.0+ seems to have an issue in rejection tracking that leads to errors in at least Firefox.

We should go back down to 3.5.5 for now.
@jryans jryans self-assigned this Oct 16, 2019
@jryans jryans added this to In Progress in Web App Team Oct 16, 2019
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 16, 2019
@jryans
Downgrade to Bluebird 3.5.5 to fix Firefox
e0b64a4 
Bluebird 3.6.0+ currently breaks in at least Firefox with errors in their
rejection tracking approach. For now, this retreats back to the version we had
used for a long time.

Regressed by #1053
Fixes element-hq/element-web#11148
@jryans jryans mentioned this issue Oct 16, 2019
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Oct 16, 2019
Web App Team automation moved this from In Review to In Test Oct 16, 2019
@jryans
Copy link
Collaborator Author

jryans commented Oct 16, 2019 •
edited
Loading

Removing release-blocker as the regressing PR was only on develop and so this fix doesn't need to land on the release branch.

@turt2live turt2live moved this from In Test to In RC in Web App Team Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
P1 T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Downgrade to Bluebird 3.5.5 to fix Firefox matrix-org/matrix-js-sdk
1 participant
@jryans