Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete security incorrectly sends you through key backup restore #11901

Closed
jryans opened this issue Jan 17, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3864
Closed

Complete security incorrectly sends you through key backup restore #11901

jryans opened this issue Jan 17, 2020 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3864
Assignees
@jryans
Labels
A-E2EE-Cross-Signing P1 T-Defect X-Release-Blocker

Comments

@jryans
Copy link
Collaborator

jryans commented Jan 17, 2020

Tom tested the complete security flow on his account with key backup, and when clicking start, he was sent into a restore key backup flow, but that's not intended.

The expected thing is you are prompted for the SSSS passphrase and the device is verified.
@jryans jryans self-assigned this Jan 17, 2020
@jryans jryans added this to In Progress in Web App Team via automation Jan 17, 2020
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Jan 17, 2020
@jryans
Convert secret storage to new account data API
ceb4581 
This converts all secret storage to use a newer account data API which uses
cached data in stored when available, but also knows how to ask the homeserver
in case it's invoked during early client startup before the initial sync.

As a consequence, it means most secret storage APIs are now async.

Part of element-hq/element-web#11901
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 17, 2020
@jryans
Adjust secret storage to work before sync
4a82e86 
This adjusts to changed JS SDK APIs that allow secret storage to optionally ask
the server for any account data needed at login.

Fixes element-hq/element-web#11901
This was referenced Jan 17, 2020
Merged
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Jan 17, 2020
Web App Team automation moved this from In Review to In Test Jan 20, 2020
@jryans jryans mentioned this issue Jan 20, 2020
Closed
@jryans jryans added the phase:1 label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Cross-Signing P1 T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust secret storage to work before sync matrix-org/matrix-react-sdk
1 participant
@jryans